Team Chat Logs

February 19, 2010

2010 1
Mo Tu We Th Fr Sa Su
1 2 3 4 5 6 7
8 9 10 11 12 13 14
15 16 17 18 19 20 21
22 23 24 25 26 27 28
<< <   > >>

[00:24:56.900512]<Hodgestar>osimons, davidfraser: Quick question about the stray .log.levels files. Are these stray files something that invalidate build now deletes? If so I'm fine with adding some upgrade functionality to do a once-off clean up.
[00:54:09.466086]<osimons>Hodgestar: yes, they are files that should have been deleted when builds where invalidated - but weren't due to wrong naming (.level)
[00:58:44.848114]<Hodgestar>osimons: Cool. Thanks.
[01:10:12.640069]<Hodgestar>osimons, davidfraser: I know David added BuildLog.LEVELS_SUFFIX to avoid these typo issues in future but I'm wary of referring to things in bitten.model from bitten.upgrades.
[01:38:18.642788]<osimons>yeah, agree. may change or may disappear later.
[01:39:51.178152]<osimons>Hodgestar: if you're happy with it and commit, i don't think david's change is merged to 0.6 yet either - could you grab that for merge at the same time?
[02:48:36.387219]<Hodgestar>osimons: Will do.
[02:49:12.805539]<Hodgestar>Attacked by work planning meeting but I'm planning to commit as soon as I've had food.
[03:52:09.210348]<Hodgestar>Committed. Now for back ports.
[03:52:37.482015]<CIA-10>r811 by osimons in doc/commands.txt: Documentation for `python:coverage` was missing for some unknown reason. Added now.
[03:52:38.565978]<CIA-10>r812 by osimons in branches/ (0.6.x/doc/commands.txt 0.6.x): Merged [811] from trunk.
[03:52:39.447930]<CIA-10>r813 by hodgestar in bitten/ (upgrades.py tests/upgrades.py model.py): Add upgrade script to fix badly named .log.level files. Don't use BuildLog.LEVELS_SUFFIX in upgrade scripts. See #517.
[04:19:49.201248]<CIA-10>r814 by hodgestar in branches/ (5 files in 3 dirs): 0.6dev: Merged [805,813] from trunk.
[05:43:58.789455]<osimons>Hodgestar: hmm..
[05:44:04.475986]<Hodgestar>Hmm?
[05:44:14.569890]<osimons>INFO: Renamed 0 incorrectly named log level files from previous migrate (0 errors)
[05:44:22.135993]<Hodgestar>Is that a problem?
[05:44:24.175969]<osimons>INFO: Deleted 0 stray log level (0 errors)
[05:44:37.548687]<Hodgestar>Do you want an if on those?
[05:44:53.553222]<Hodgestar>Or is it not deleting what it should?
[05:44:55.499962]<osimons>i got a lot of stray files - expected them to disappear
[05:45:15.431292]<Hodgestar>:(
[05:45:41.202573]<osimons>harmless though, so no worries :-)
[05:46:02.246365]<Hodgestar>I wonder if the upgrade found the right logs_dir?
[05:46:16.525836]<osimons>if not wrong_filename.endswith('.log.level'): => all my stray .levels files are skipped
[05:46:50.462547]<osimons>earlier builds deleted .log + .level files (which did not exist of course - leaving the .levels files stray)
[05:47:08.512627]<Hodgestar>I didn't know the .levels files needed deleting? My change intentionally only fiddles with .log.level files.
[05:48:13.723008]<Hodgestar>Hmm. I misread the comments in #517. :/
[05:49:27.301099]<osimons>now i'm confused too. can't find the delete for .level in the changesets as expected. hmmf. was that and older change?
[05:50:23.216876]<Hodgestar>osimons: Line 431 in r813.
[05:53:21.540778]<osimons>http://bitten.edgewall.org/changeset/714
[05:53:32.497195]<osimons>hmm. that long ago? more confused now...
[05:53:57.444843]<Hodgestar>Wait, what are you looking for?
[05:55:06.360742]<osimons>right - oldest stray .levels files i've got is from august... time flies, i guess...
[05:55:15.441529]<Hodgestar>Oh. I see.
[05:55:23.188056]<Hodgestar>I think.
[05:55:24.607081]<osimons>before r714, .levels files were not deleted at all.
[05:55:31.250390]<Hodgestar>Ah.
[05:55:43.019914]<osimons>so i added that - but no upgrade it seems.
[05:56:04.741826]<Hodgestar>I can add deletion of stray .levels files too if that helps?
[05:57:13.724719]<osimons>it is harmless, so i guess we can just add a small conditional to it that handles the file if no corresponding .levels file exists? should be a small fix, i see - and your current .level logic will likely never catch anything...
[05:58:10.559339]<osimons>just update the same script
[05:58:15.715932]<Hodgestar>It won't? What about .level files from earlier upgrades that then had the associated build invalidated?
[05:59:03.554985]<osimons>uh. perhaps. i don't have those, but i suppose that may well happen.
[05:59:39.816269]<osimons>no harm leaving the code in of course
[06:00:57.363183]<Hodgestar>So just add an extra step in the loop that removes stray .levels files too?
[06:01:16.338239]<osimons>yeah - and perhaps a stray .levels file in the test too
[06:01:42.951678]<Hodgestar>Indeed.
[06:03:07.596514]<osimons>sorry for not quite remembering all the details here, Hodgestar... i did think we got it right this time... :-)
[06:03:24.509949]<Hodgestar>:)
[06:03:25.944166]<Hodgestar>Np.
[08:27:50.985655]<Hodgestar>osimons: I think removing stray .log.levels files that result from a one point not remove such files when builds were delete is separate to the stray .log.level issue so I'll make a separate upgrade function (and test) for it but not bump the schema level.
[08:27:54.916533]<Hodgestar>Sounds good?
[09:14:47.416134]<osimons>sure, Hodgestar - no need to bump schema for this one. add a separate method if that makes more sense. at least if you can get it done quickly, then most/all will run that upgrade anyway.
[09:15:57.251345]<osimons>- which i guess in hindsight i should have done back then, or at least included in some previous schema update. it is the kind of thing that is nice to get done, but not important in itself... :-)
[09:20:47.145915]<Hodgestar>I've done the actual coding but have dinner guests. Will commit a bit later.